Changes

[transport-xmpp] Bump Smack to 4.4.0-beta2

MAXS Release 0.5.11

MAXS 0.5.12-SNAPSHOT

[module-shell] Update root-commands

To include a version with suppresses the MissingPermission lint
check for the reboot() method.

Update Android Gradle plugin to 4.1.0

[transport-xmpp] Bump Smack to 4.4.0-rc2

[transport-xmpp] Add more disabled Smack classes

Remove build/proguard-project-shared.txt

The Android Gradle plugin idiomatic configuration already contain a
default Android platform specific configuration, via
getDefaultProguardFile().

[transport-xmpp] Configure proguard to not obfuscate the code

[transport-xmpp] Add, commented out, proguard debug options

[transport-xmpp] Disable R8 (minifyEnabled false, formerly ProGuard)

This appears to case some strange issues if optimization is
enabled. For example a try-catch does not catch a thrown exception in
a static class initialization block:

11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207): MAXSTransportService[XMPP] thread: uncaught Exception!
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207): java.util.ServiceConfigurationError: org.jivesoftware.smack.xml.XmlPullParserFactory: Provider org.jivesoftware.smack.xml.xpp3.Xpp3XmlPullParserFactory could not be instantiated
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at java.util.ServiceLoader.fail(ServiceLoader.java:233)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at java.util.ServiceLoader.access$100(ServiceLoader.java:183)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:392)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:416)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at java.util.ServiceLoader$1.next(ServiceLoader.java:494)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at org.jivesoftware.smack.xml.SmackXmlParser.getXmlPullParserFactory(SmackXmlParser.java:37)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at org.jivesoftware.smack.xml.SmackXmlParser.newXmlParser(SmackXmlParser.java:54)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at org.jivesoftware.smack.util.PacketParserUtils.getParserFor(PacketParserUtils.java:80)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at org.jivesoftware.smack.SmackInitialization.processConfigFile(SmackInitialization.java:159)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at org.jivesoftware.smack.SmackInitialization.processConfigFile(SmackInitialization.java:154)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at org.jivesoftware.smack.SmackInitialization.<clinit>(SmackInitialization.java:103)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at org.jivesoftware.smack.SmackConfiguration.getVersion(SmackConfiguration.java:110)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at org.jivesoftware.smack.provider.ProviderManager.<clinit>(ProviderManager.java:125)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at org.jivesoftware.smack.provider.ProviderManager.addExtensionProvider(ProviderManager.java:265)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at org.projectmaxs.transport.xmpp.smack.provider.MAXSElementProvider.setup(MAXSElementProvider.java:38)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at org.projectmaxs.transport.xmpp.xmppservice.XMPPService.<clinit>(XMPPService.java:153)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at org.projectmaxs.transport.xmpp.xmppservice.XMPPService.getInstance(Unknown Source:0)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at org.projectmaxs.transport.xmpp.TransportService.onHandleIntent(TransportService.java:114)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at org.projectmaxs.shared.transport.MAXSTransportService$ServiceHandler.handleMessage(MAXSTransportService.java:74)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at android.os.Handler.dispatchMessage(Handler.java:106)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at android.os.Looper.loop(Looper.java:223)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at android.os.HandlerThread.run(HandlerThread.java:67)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207): Caused by: java.lang.ExceptionInInitializerError
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at java.lang.Class.newInstance(Native Method)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:388)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  ... 19 more
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207): Caused by: org.xmlpull.v1.XmlPullParserException: unsupported feature: http://xmlpull.org/v1/doc/features.html#xml-roundtrip (position:START_DOCUMENT null@1:1)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at com.android.org.kxml2.io.KXmlParser.setFeature(KXmlParser.java:2102)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  at org.jivesoftware.smack.xml.xpp3.Xpp3XmlPullParserFactory.<clinit>(Xpp3XmlPullParserFactory.java:46)
11-18 18:20:43.955 E/MAXS/MAXSTransportService(27207):  ... 21 more

This exception disappears if we disable optimization in R8(/formerly
ProGuard). But even if it is disabled R8 strips stuff

11-18 19:45:51.301 E/AndroidRuntime( 8469): java.lang.ExceptionInInitializerError
11-18 19:45:51.301 E/AndroidRuntime( 8469):     at org.jivesoftware.smack.SmackConfiguration.getVersion(SmackConfiguration.java:110)
11-18 19:45:51.301 E/AndroidRuntime( 8469):     at org.jivesoftware.smack.provider.ProviderManager.<clinit>(ProviderManager.java:125)
11-18 19:45:51.301 E/AndroidRuntime( 8469):     at org.jivesoftware.smack.provider.ProviderManager.addExtensionProvider(ProviderManager.java:265)
11-18 19:45:51.301 E/AndroidRuntime( 8469):     at org.projectmaxs.transport.xmpp.smack.provider.MAXSElementProvider.setup(MAXSElementProvider.java:38)
11-18 19:45:51.301 E/AndroidRuntime( 8469):     at org.projectmaxs.transport.xmpp.xmppservice.XMPPService.<clinit>(XMPPService.java:153)
11-18 19:45:51.301 E/AndroidRuntime( 8469):     at org.projectmaxs.transport.xmpp.xmppservice.XMPPService.getInstance(Unknown Source:0)
11-18 19:45:51.301 E/AndroidRuntime( 8469):     at org.projectmaxs.transport.xmpp.TransportService.onHandleIntent(TransportService.java:114)
11-18 19:45:51.301 E/AndroidRuntime( 8469):     at org.projectmaxs.shared.transport.MAXSTransportService$ServiceHandler.handleMessage(MAXSTransportService.java:74)
11-18 19:45:51.301 E/AndroidRuntime( 8469):     at android.os.Handler.dispatchMessage(Handler.java:106)
11-18 19:45:51.301 E/AndroidRuntime( 8469):     at android.os.Looper.loop(Looper.java:223)
11-18 19:45:51.301 E/AndroidRuntime( 8469):     at android.os.HandlerThread.run(HandlerThread.java:67)
11-18 19:45:51.301 E/AndroidRuntime( 8469): Caused by: java.lang.IllegalArgumentException: The class org.jivesoftware.smack.sasl.packet.SaslNonza$Challenge has no ELEMENT, NAMESPACE or QNAME member. Consider adding QNAME
11-18 19:45:51.301 E/AndroidRuntime( 8469):     at org.jivesoftware.smack.util.XmppElementUtil.getQNameFor(XmppElementUtil.java:66)
11-18 19:45:51.301 E/AndroidRuntime( 8469):     at org.jivesoftware.smack.provider.ProviderManager.addNonzaProvider(ProviderManager.java:330)
11-18 19:45:51.301 E/AndroidRuntime( 8469):     at org.jivesoftware.smack.SmackInitialization.<clinit>(SmackInitialization.java:137)
11-18 19:45:51.301 E/AndroidRuntime( 8469):     ... 11 more
11-18 19:45:51.301 E/AndroidRuntime( 8469): Caused by: java.lang.NoSuchFieldException: ELEMENT
11-18 19:45:51.301 E/AndroidRuntime( 8469):     at java.lang.Class.getField(Class.java:1604)
11-18 19:45:51.301 E/AndroidRuntime( 8469):     at org.jivesoftware.smack.util.XmppElementUtil.getQNameFor(XmppElementUtil.java:62)
11-18 19:45:51.301 E/AndroidRuntime( 8469):     ... 13 more

my first attempts to fix this includes

--keep class * implements org.jivesoftware.smack.provider.IQProvider
--keep class * implements org.jivesoftware.smack.provider.ExtensionElementProvider
--keep class * extends org.jivesoftware.smack.packet.Stanza
+-keep class * implements org.jivesoftware.smack.provider.AbstractProvider
+#-keep class * extends org.jivesoftware.smack.packet.Stanza
+-keep class org.jivesoftware.smack.packet.Element
+-keep class * implements org.jivesoftware.smack.packet.Element {
+    public static String QNAME;
+    public static String ELEMENT;
+    public static String NAMESPACE;
+}

but that did not (yet) work. So we disable R8 for now.

MAXS Release 0.5.12

MAXS 0.5.13-SNAPSHOT

Remove stale scripts/MavenToAndroidAnt git submodule